Re: [Qemu-devel] [PATCH] target-mips: Remove semicolon from macro definition

[Peter Maydell]

On 22 December 2012 12:38, Stefan Weil <address@hidden> wrote:
> Macro RESTORE_FLUSH_MODE is similar to RESTORE_ROUNDING_MODE
> but included a semicolon.
>
> The code which uses that macro also includes a semicolon,
> so the result was an empty statement.
>
> Remove the superfluous semicolon from the macro definition.
>
> Signed-off-by: Stefan Weil <address@hidden>

FWIW I think it would be better to just turn these two macros into
static inline functions which took a CPUMIPSState *env argument.
Macros which don't take arguments but silently use variables from
their caller are a bit ugly, and in this case there's no need to do it
that way.

-- PMM