Re: [Qemu-devel] [PATCH 1/2] tcg-hppa: Fix brcond2 and setcond2

[Stuart Brady]

On Tue, Sep 18, 2012 at 07:59:47PM -0700, Richard Henderson wrote:
> diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-target.c
> index 8b81b70..a76569d 100644
> --- a/tcg/hppa/tcg-target.c
> +++ b/tcg/hppa/tcg-target.c
> @@ -820,19 +820,34 @@ static void tcg_out_comclr(TCGContext *s, int cond, 
> TCGArg ret,
>      tcg_out32(s, op);
>  }
[...]
>      case TCG_COND_NE:
> -        tcg_out_comclr(s, tcg_invert_cond(cond), TCG_REG_R0, al, bl, 
> blconst);
> -        tcg_out_brcond(s, cond, ah, bh, bhconst, label_index);
> +        tcg_out_brcond(s, TCG_COND_NE, al, bl, bhconst, label_index);
> +        tcg_out_brcond(s, TCG_COND_NE, ah, bh, bhconst, label_index);
>          break;

I'm not sure whether it's possible to have blconst != bhconst, but I see
that 'bhconst' is accidentally used together with 'al' and 'bl' here.
It may be some time before I get around to submitting a patch for this,
so just mentioning it briefly.
-- 
Cheers,

Stuart Brady