qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 16/20] target-i386: set custom 'level' without i


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 16/20] target-i386: set custom 'level' without intermediate x86_def_t
Date: Thu, 27 Dec 2012 17:32:25 -0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Dec 27, 2012 at 03:59:32PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>

Reviewed-by: Eduardo Habkost <address@hidden>

Now I am starting to see why you are using featurestr in the qdict_put()
calls.  :-)

> ---
>  target-i386/cpu.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index d8af528..1cb2f08 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1319,13 +1319,7 @@ static int cpu_x86_parse_featurestr(x86_def_t 
> *x86_cpu_def, char *features,
>                  }
>                  x86_cpu_def->stepping = numvalue ;
>              } else if (!strcmp(featurestr, "level")) {
> -                char *err;
> -                numvalue = strtoul(val, &err, 0);
> -                if (!*val || *err) {
> -                    fprintf(stderr, "bad numerical value %s\n", val);
> -                    goto error;
> -                }
> -                x86_cpu_def->level = numvalue;
> +                qdict_put(*props, featurestr, qstring_from_str(val));
>              } else if (!strcmp(featurestr, "xlevel")) {
>                  char *err;
>                  numvalue = strtoul(val, &err, 0);
> -- 
> 1.7.1
> 

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]