Re: [Qemu-devel] [PATCH 10/20] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

[Eduardo Habkost]

On Thu, Dec 27, 2012 at 03:59:26PM +0100, Igor Mammedov wrote:
[...]
>      assert(kvm_enabled());
>  
>      x86_cpu_def->name = "host";
> -    host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx);
> -    x86_cpu_def->vendor1 = ebx;
> -    x86_cpu_def->vendor2 = edx;
> -    x86_cpu_def->vendor3 = ecx;
> +    x86cpu_vendor_words2str(x86_cpu_def->vendor, ebx, edx, ecx);

Oops: you removed the host_cpuid() call by mistake, so now we're filling
the vendor string with zeroes.

Reviewed-by withdrawn.

-- 
Eduardo