qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/20] target-i386: replace uint32_t vendor fiel


From: Igor Mammedov
Subject: Re: [Qemu-devel] [PATCH 10/20] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t
Date: Fri, 28 Dec 2012 21:01:47 +0100

On Fri, 28 Dec 2012 15:39:19 -0200
Eduardo Habkost <address@hidden> wrote:

> On Thu, Dec 27, 2012 at 03:59:26PM +0100, Igor Mammedov wrote:
> [...]
> >      assert(kvm_enabled());
> >  
> >      x86_cpu_def->name = "host";
> > -    host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx);
> > -    x86_cpu_def->vendor1 = ebx;
> > -    x86_cpu_def->vendor2 = edx;
> > -    x86_cpu_def->vendor3 = ecx;
> > +    x86cpu_vendor_words2str(x86_cpu_def->vendor, ebx, edx, ecx);
> 
> Oops: you removed the host_cpuid() call by mistake, so now we're filling
> the vendor string with zeroes.
fixed in v4 series

Thanks!

> 
> Reviewed-by withdrawn.
> 
> -- 
> Eduardo


-- 
Regards,
  Igor



reply via email to

[Prev in Thread] Current Thread [Next in Thread]