[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix semaphores fallback code
From: |
Brad Smith |
Subject: |
Re: [Qemu-devel] [PATCH] Fix semaphores fallback code |
Date: |
Fri, 28 Dec 2012 16:11:04 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Dec 28, 2012 at 08:13:37PM +0000, Blue Swirl wrote:
> On Fri, Dec 28, 2012 at 6:00 AM, Brad Smith <address@hidden> wrote:
> > As reported in bug 1087114 the semaphores fallback code is broken which
> > results in QEMU crashing and making QEMU unusable.
> >
> > This patch is from Paolo.
> >
> > This needs to be back ported to the 1.3 stable tree as well.
>
> Needs to be back ported to HEAD as well because of the reorganization,
> or applied after Paolo's series.
>
> >
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Brad Smith <address@hidden>
Here is a patch applied to HEAD.
diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
index 6374df3..4489abf 100644
--- a/qemu-thread-posix.c
+++ b/qemu-thread-posix.c
@@ -213,6 +213,7 @@ int qemu_sem_timedwait(QemuSemaphore *sem, int ms)
while (sem->count < 0) {
rc = pthread_cond_timedwait(&sem->cond, &sem->lock, &ts);
if (rc == ETIMEDOUT) {
+ ++sem->count;
break;
}
if (rc != 0) {
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.