Re: [Qemu-devel] [PATCH] target-mips: Remove semicolon from macro definition

[Aurelien Jarno]

On Sat, Dec 22, 2012 at 01:38:19PM +0100, Stefan Weil wrote:
> Macro RESTORE_FLUSH_MODE is similar to RESTORE_ROUNDING_MODE
> but included a semicolon.
> 
> The code which uses that macro also includes a semicolon,
> so the result was an empty statement.
> 
> Remove the superfluous semicolon from the macro definition.
> 
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> 
> Note:
> 
> After the patch, the modified line is shorter, but still longer than
> required by the coding conventions.
> 
>  target-mips/op_helper.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index e85edce..e3ab05c 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -2175,7 +2175,7 @@ static unsigned int ieee_rm[] = {
>      set_float_rounding_mode(ieee_rm[env->active_fpu.fcr31 & 3], 
> &env->active_fpu.fp_status)
>  
>  #define RESTORE_FLUSH_MODE \
> -    set_flush_to_zero((env->active_fpu.fcr31 & (1 << 24)) != 0, 
> &env->active_fpu.fp_status);
> +    set_flush_to_zero((env->active_fpu.fcr31 & (1 << 24)) != 0, 
> &env->active_fpu.fp_status)
>  
>  target_ulong helper_cfc1(CPUMIPSState *env, uint32_t reg)
>  {

Thanks, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net