Re: [Qemu-devel] [PATCH] Change to correct PowerPC on a 64bit host

[Peter Maydell]

On 2 January 2013 13:01, Samuel Seay <address@hidden> wrote:
> The VM I did the work in doesn't have internet access and I was unsure how
> to do a text only email with gmail. With that said, the line that removed
> the env->gpr[1] is redudant as a few lines below in the original source it
> is set with newsp. The removed line would seg fault due to trying to write
> the value of env->gpr[1] into newsp, which is not valid in host.

No, it's not redundant -- we must save the old value of gpr[1], exactly
because we are about to change it (set it to newsp). The code is trying
to do the right thing (copy the old env->gpr[1] value into the guest
stack frame it is setting up) but in a broken way, so it must be fixed,
not just removed.

-- PMM