Re: [Qemu-devel] [PATCH] s390x: Remove inline function ebcdic_put and related data from cpu.h

[Alexander Graf]

On 01.01.2013, at 19:24, Stefan Weil wrote:

> The function is only used in misc_helper.c, so move it to that file.
> 
> This reduces the size of debug executables (compiled without optimization)
> because they get unused code and data for each compilation which includes
> cpu.h.
> 
> Executables with optimization don't change their size.
> 
> ebcdic2ascii is currently unused and could be removed (not done here).
> 
> The array ascii2ebcdic must be accessed with an unsigned index, therefore
> (int)ascii[i] was replaced by (uint8_t)ascii[i]. The old code would have
> failed for a signed char less than 0. The current code only converts
> "QEMU" and spaces to EBCDIC, so there is no problem today.
> 
> Signed-off-by: Stefan Weil <address@hidden>

Thanks, applied to s390-next.

Alex