[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] Modifications to fix PowerPC on 6
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH v3] Modifications to fix PowerPC on 64bit host, bug 1052857 |
|
Date: |
Thu, 3 Jan 2013 17:28:22 +0000 |
On 3 January 2013 14:45, Alexander Graf <address@hidden> wrote:
>
> On 02.01.2013, at 21:53, Samuel Seay wrote:
>
>> Removed h2g() macro around the ka->_sa_handler due to the _sa_handler being
>> a guest memory address
>> Changed the __put_user to put_user as it was attempting to put a value at
>> the stack address but the new address is a guest memory address, __put_user
>> is for host memory addresses.
>> Patch v2 -> v3, removed unneeded casting in the put_user call left over from
>> __put_user
>>
>> Signed-off-by: Samuel Seay <address@hidden>
>
> Looks reasonable to me, but I'd like an ack from Peter.
Untested, and I haven't looked up the PPC ABI to check that the
function is overall doing the right thing, but with those caveats:
Reviewed-by: Peter Maydell <address@hidden>
-- PMM