Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

[Anthony Liguori]

Peter Maydell <address@hidden> writes:

> On 3 January 2013 19:00, Anthony Liguori <address@hidden> wrote:
>> Thanks, applied.
>
> So we now say "char device redirected to /dev/pts/5 (compat_monitor0)"
> rather than "char device compat_monitor0 redirected to /dev/pts/5" ?
> I think that's a reduction in clarity and it's sad that we have to do it.
>
> I also think that everywhere we have something with a specific
> format which we're retaining for the benefit of libvirt we should
> have big warning comments saying "Do not change this because
> libvirt versions older than X.Y depend upon the exact text".
> Otherwise we'll just trip over the same bugs again later.

I don't intend that we keep this forever.   But it's hardly compelling
to do it one way vs. the other so compatibility wins.

Regards,

Anthony Liguori

>
> -- PMM