[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/6] spice: drop incorrect vm_change_state_handler()
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 6/6] spice: drop incorrect vm_change_state_handler() opaque |
Date: |
Fri, 4 Jan 2013 14:55:50 +0100 |
The spice_server pointer is a global variable and
vm_change_state_handler() therefore does not use its opaque parameter.
The vm change state handler is added with a pointer to the spice_server
pointer. This is useless and we probably would not want 2 levels of
pointers.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Uri Lublin <address@hidden>
---
ui/spice-core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 3e44779..d83de2a 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -709,7 +709,7 @@ void qemu_spice_init(void)
qemu_spice_input_init();
qemu_spice_audio_init();
- qemu_add_vm_change_state_handler(vm_change_state_handler, &spice_server);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
g_free(x509_key_file);
g_free(x509_cert_file);
@@ -736,8 +736,7 @@ int qemu_spice_add_interface(SpiceBaseInstance *sin)
*/
spice_server = spice_server_new();
spice_server_init(spice_server, &core_interface);
- qemu_add_vm_change_state_handler(vm_change_state_handler,
- &spice_server);
+ qemu_add_vm_change_state_handler(vm_change_state_handler, NULL);
}
return spice_server_add_interface(spice_server, sin);
--
1.8.0.2
- [Qemu-devel] [PULL 0/6] Trivial patches for 18 December 2012 to 4 January 2013, Stefan Hajnoczi, 2013/01/04
- [Qemu-devel] [PATCH 2/6] pseries: Remove unneeded include statement (fixes MinGW builds), Stefan Hajnoczi, 2013/01/04
- [Qemu-devel] [PATCH 1/6] pc_sysfw: Check for qemu_find_file() failure, Stefan Hajnoczi, 2013/01/04
- [Qemu-devel] [PATCH 4/6] hw/mcf5206: Reduce size of lookup table, Stefan Hajnoczi, 2013/01/04
- [Qemu-devel] [PATCH 6/6] spice: drop incorrect vm_change_state_handler() opaque,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 5/6] linux-user/syscall.c: remove forward declarations, Stefan Hajnoczi, 2013/01/04
- [Qemu-devel] [PATCH 3/6] Remove --sparc_cpu option from the configure list, Stefan Hajnoczi, 2013/01/04
- Re: [Qemu-devel] [PULL 0/6] Trivial patches for 18 December 2012 to 4 January 2013, Anthony Liguori, 2013/01/04