Re: [Qemu-devel] [PATCH] pixman: fix warning

[Peter Maydell]

On 4 January 2013 14:59, Gerd Hoffmann <address@hidden> wrote:
> Cc: address@hidden
> Cc: address@hidden
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  include/ui/qemu-pixman.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h
> index 3c05c83..63b8ccc 100644
> --- a/include/ui/qemu-pixman.h
> +++ b/include/ui/qemu-pixman.h
> @@ -6,7 +6,11 @@
>  #ifndef QEMU_PIXMAN_H
>  #define QEMU_PIXMAN_H
>
> +/* pixman-0.16.0 headers have a redundant declaration */
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wredundant-decls"
>  #include <pixman.h>
> +#pragma GCC diagnostic pop

IIRC we can't rely on gcc knowing about 'diagnostic push/pop' --
eg in coroutine-ucontext.c we avoid using that for this reason.

-- PMM