[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support. |
|
Date: |
Fri, 4 Jan 2013 18:25:12 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jan 04, 2013 at 09:02:28PM +0530, Onkar N Mahajan wrote:
> @@ -695,7 +695,7 @@ static int coroutine_fn
> bdrv_qed_co_is_allocated(BlockDriverState *bs,
>
> static int bdrv_qed_make_empty(BlockDriverState *bs)
> {
> - return -ENOTSUP;
> + return 0;
> }
The only .bdrv_make_empty() caller is block.c:bdrv_commit():
if (drv->bdrv_make_empty) {
ret = drv->bdrv_make_empty(bs);
bdrv_flush(bs);
}
Perhaps it's best to drop bdrv_qed_make_empty() completely so
bdrv_commit() succeeds but we don't pretend to support
.bdrv_make_empty().
Stefan