[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: fix copy_to_user_fdset fo
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: fix copy_to_user_fdset for fds over 30 |
|
Date: |
Fri, 04 Jan 2013 10:57:07 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/03/2013 02:02 AM, Nickolai Zeldovich wrote:
> - v |= ((FD_ISSET(k, fds) != 0) << j);
> + v |= (((abi_ulong) (FD_ISSET(k, fds) != 0)) << j);
It would be easier to read if you dropped the unnecessary parens.
v |= (abi_ulong)(FD_ISSET(k, fds) != 0) << j;
Otherwise the change looks correct.
r~