[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/11] qdev: correct reference counting
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 00/11] qdev: correct reference counting |
Date: |
Mon, 07 Jan 2013 14:31:48 -0600 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Paolo Bonzini <address@hidden> writes:
> This series makes the ref_count field of device and bus objects actually
> match the number of references that the objects have. Once this is done,
> qdev_free and qbus_free are equivalent to simply object_unparent, and
> object_delete can go.
>
> Patches 1-3 fix some warts in the last minute patches that went in 1.3.
> Patches 4-9 are the bulk of the series. Patches 10-11 touches the CPU
> classes instead.
Other than the few minor comments:
Reviewed-by: Anthony Liguori <address@hidden>
Thanks for spending time on this. It's a PITA to get right.
Regards,
Anthony Liguori
>
> Paolo
>
> Paolo Bonzini (11):
> qdev: export and use qbus_init
> qdev: use object_new, not g_malloc to create buses
> qom: preserve object while unparenting it
> qdev: add reference count to a device for the BusChild
> qdev: move deletion of children from finalize to unparent
> qdev: move unrealization of devices from finalize to unparent
> qdev: add reference for the bus while it is referred to by the
> DeviceState
> qdev: inline object_delete into qbus_free/qdev_free
> qdev: drop extra references at creation time
> cpu: do not use object_delete
> qom: remove object_delete
>
> hw/pci.c | 11 +++---
> hw/pci.h | 5 ---
> hw/qdev-core.h | 1 +
> hw/qdev-monitor.c | 5 ++-
> hw/qdev.c | 107
> +++++++++++++++++++++++++++++---------------------
> hw/sysbus.c | 6 +--
> include/qemu/object.h | 17 +-------
> linux-user/syscall.c | 2 +-
> qom/object.c | 9 +----
> target-i386/helper.c | 4 +-
> target-sparc/cpu.c | 2 +-
> vl.c | 1 +
> 12 files changed, 84 insertions(+), 86 deletions(-)
>
> --
> 1.8.0.1
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 00/11] qdev: correct reference counting,
Anthony Liguori <=