[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command |
Date: |
Mon, 07 Jan 2013 15:04:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/06/2013 03:06 AM, Lei Li wrote:
> Signed-off-by: Lei Li <address@hidden>
> ---
> qga/commands-posix.c | 12 ++++++++++++
> qga/qapi-schema.json | 17 +++++++++++++++++
> 2 files changed, 29 insertions(+), 0 deletions(-)
>
> +++ b/qga/qapi-schema.json
> @@ -100,6 +100,23 @@
> 'utc-offset': 'int' } }
>
> ##
> +# @guest-get-time:
> +#
> +# Get the information about host time in UTC and the
> +# UTC offset.
About the host time, or about the guest time? In other words, doesn't
this command exist for the host to ask the guest what time the _guest_
thinks it is, so that the host can then decide whether to issue a
followup command to tell the guest to adjust its time?
> +#
> +# This command tries to get the host time which is
> +# presumably correct, since need to be able to resynchronize
> +# clock to host in guest.
> +#
> +# Returns: @HostTimeInfo on success.
For that matter, should we name the type in patch 1/3 'TimeInfo',
instead of 'HostTimeInfo', as it is not intrinsically tied to host or
guest, but more a function of who is being queried?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 2/3] qga: add guest-get-time command, Lei Li, 2013/01/06
- Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command,
Eric Blake <=
Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command, Luiz Capitulino, 2013/01/09
[Qemu-devel] [PATCH 3/3] qga: add guest-set-time command, Lei Li, 2013/01/06
Re: [Qemu-devel] [RFC PATCH 0/3] Time resync support by qemu-ga, Eric Blake, 2013/01/07