[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation |
Date: |
Tue, 8 Jan 2013 16:57:54 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Jan 08, 2013 at 02:55:56PM +0100, Andreas Färber wrote:
> IPACK_DEVICE()
>
> You have them defined in the header, please use them consistently.
>
> Also, please avoid accessing internals like &s->bus.qbus
> (BUS(s->bus)) or &s->dev.qdev (DEVICE(s->dev)).
Ok, I'm using all the defined macros and replaced all instances of
DO_UPCAST() with their checked equivalents.
I also removed all accesses to internals.
And I defined ipack_bus_new_inplace() (in the spirit of
pci_bus_new_inplace()) and updated tpci200_initfn().
Tell me if there's anything else I should change, else I can post the
new patches.
> Another thing to check (could be a follow-up) is whether the initfn
> can be split into instance_init (e.g., pci_set_*?) and initfn.
What's exactly that for in this case?
Berto