[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock structure.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock structure. |
Date: |
Tue, 8 Jan 2013 16:18:53 +0000 |
On 7 January 2013 18:40, <address@hidden> wrote:
> virtio-blk : show VirtIOBlock structure.
If this survives as a separate patch then this should read
"virtio-blk: make VirtIOBlock structure public"
> As we discuss with anthony and andreas, this structure must be showed to avoid
> two memory allocations for virtio-blk-x.
I don't really like chatty references to mailing list discussions in
commit messages; commit messages should just confidently
say what/why they're making the change. You can always put
in remarks below the '---' line if you want to remind reviewers of
earlier discussion. Similarly, you don't need to say "must be
committed after patches X and Y" in the commit message proper --
as a git commit the order is inherent.
-- PMM
- [Qemu-devel] [PATCH 00/61] Virtio refactoring., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 01/61] qdev : add a maximum device allowed field for the bus., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 03/61] virtio-pci-bus : introduce virtio-pci-bus., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 02/61] virtio-bus : introduce virtio-bus, fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 04/61] virtio-pci : refactor virtio-pci device., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 06/61] virtio-s390-bus : add virtio-s390-bus., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 05/61] virtio-device : refactor virtio-device., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 07/61] virtio-s390-device : create a virtio-s390-bus during init., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock structure., fred . konrad, 2013/01/07
- Re: [Qemu-devel] [PATCH 08/61] virtio-blk : show VirtIOBlock structure.,
Peter Maydell <=
- [Qemu-devel] [PATCH 09/61] virtio-blk : don't use pointer for configuration., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 10/61] virtio-blk : add the virtio-blk device., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 12/61] virtio-blk-s390 : switch to the new API., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 11/61] virtio-blk-pci : switch to new API., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 14/61] virtio-blk : cleanup : remove qdev field., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 16/61] virtio-net : add the virtio-net device., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 17/61] virtio-net-pci : switch to the new API., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 15/61] virtio-net : show the VirtIONet structure., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 13/61] virtio-blk : cleanup : use QOM cast., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 20/61] virtio-net : cleanup : init and exit function., fred . konrad, 2013/01/07