Re: [Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation

[Alberto Garcia]

On Wed, Jan 09, 2013 at 01:36:50AM +0100, Andreas Färber wrote:

> > I also removed all accesses to internals.
> 
> qdev->parent_bus is not supposed to be accessed either, there is
> qdev_get_parent_bus() as accessor function.

Yeah, that one I had also changed :)

(I didn't find any accessor for qbus->parent, so that one I didn't
change).

> > And I defined ipack_bus_new_inplace() (in the spirit of
> > pci_bus_new_inplace()) and updated tpci200_initfn().
> 
> Note that Paolo has a series refactoring the in-place bus init
> (either for qdev reset or for QOM reference counting) that you may
> want to take into account then.

I guess you mean 
https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg00548.html

I anyway didn't really change anything, I just moved the
qbus_create_inplace() call to ipack.c, so the fields of IPackBus are
not directly accessed from tpci200.

> Having the IPackBus not be a pointer but part of the exposing device
> initialized in-place would be desirable long-term but, like some
> other issues raised, not a criteria for initial patch acceptance
> IMO.

IPackBus is not a pointer, it is part of TPCI200State and is being
initialized in-place ...

Berto