[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu 0/7] disable kvm_mmu + -cpu "enforce" fi
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu 0/7] disable kvm_mmu + -cpu "enforce" fixes (v3) |
Date: |
Wed, 9 Jan 2013 17:21:49 +0200 |
On Mon, Jan 07, 2013 at 04:20:41PM -0200, Eduardo Habkost wrote:
> Changes on v3:
> - Patches 3-9 from v2 are now already on qom-cpu tree
> - Remove CONFIG_KVM #ifdefs by declaring fake KVM_* #defines on sysemu/kvm.h
> - Refactor code that uses the feature word arrays
> (to make it easier to add a new feature name array)
> - Add feature name array for CPUID leaf 0xC0000001
>
> Changes on v2:
> - Now both the kvm_mmu-disable and -cpu "enforce" changes are on the same
> series
> - Coding style fixes
>
> Git tree for reference:
> git://github.com/ehabkost/qemu-hacks.git cpu-enforce-all.v3
> https://github.com/ehabkost/qemu-hacks/tree/cpu-enforce-all.v3
>
> The changes are a bit intrusive, but:
>
> - The longer we take to make "enforce" strict as it should (and make libvirt
> finally use it), more users will have VMs with migration-unsafe
> unpredictable
> guest ABIs. For this reason, I would like to get this into QEMU 1.4.
> - The changes in this series should affect only users that are already using
> the "enforce" flag, and I believe whoever is using the "enforce" flag
> really
> want the strict behavior introduced by this series.
>
>
>
Reviewed-by: Gleb Natapov <address@hidden>
Small comment on patch 4. Fill free to ignore.
> Eduardo Habkost (7):
> kvm: Add fake KVM constants to avoid #ifdefs on KVM-specific code
> target-i386: Don't set any KVM flag by default if KVM is disabled
> target-i386: Disable kvm_mmu by default
> target-i386/cpu: Introduce FeatureWord typedefs
> target-i386: kvm_check_features_against_host(): Use feature_word_info
> target-i386/cpu.c: Add feature name array for ext4_features
> target-i386: check/enforce: Check all feature words
>
> include/sysemu/kvm.h | 14 ++++
> target-i386/cpu.c | 193
> ++++++++++++++++++++++++++++++++-------------------
> target-i386/cpu.h | 15 ++++
> 3 files changed, 150 insertions(+), 72 deletions(-)
>
> --
> 1.7.11.7
--
Gleb.
- Re: [Qemu-devel] [PATCH qom-cpu 2/7] target-i386: Don't set any KVM flag by default if KVM is disabled, (continued)
- [Qemu-devel] [PATCH qom-cpu 1/7] kvm: Add fake KVM constants to avoid #ifdefs on KVM-specific code, Eduardo Habkost, 2013/01/07
- [Qemu-devel] [PATCH qom-cpu 6/7] target-i386/cpu.c: Add feature name array for ext4_features, Eduardo Habkost, 2013/01/07
- [Qemu-devel] [PATCH qom-cpu 3/7] target-i386: Disable kvm_mmu by default, Eduardo Habkost, 2013/01/07
- [Qemu-devel] [PATCH qom-cpu 7/7] target-i386: check/enforce: Check all feature words, Eduardo Habkost, 2013/01/07
- [Qemu-devel] [PATCH qom-cpu 5/7] target-i386: kvm_check_features_against_host(): Use feature_word_info, Eduardo Habkost, 2013/01/07
- [Qemu-devel] [PATCH qom-cpu 4/7] target-i386/cpu: Introduce FeatureWord typedefs, Eduardo Habkost, 2013/01/07
- Re: [Qemu-devel] [PATCH qom-cpu 0/7] disable kvm_mmu + -cpu "enforce" fixes (v3),
Gleb Natapov <=
- Re: [Qemu-devel] [PATCH qom-cpu 0/7] disable kvm_mmu + -cpu "enforce" fixes (v3), Andreas Färber, 2013/01/10