[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images.
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images. |
Date: |
Wed, 09 Jan 2013 15:53:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/08/2013 10:12 PM, Wenchao Xia wrote:
> This mirror function will return all image info including
> snapshots. Now Qemu have both query-images and query-block
> interfaces.
>
> V2:
> Redesign the interface, it will show related block device name now.
> Added counter part in qmp-commands.hx.
> Using plurals in API name.
Again, patch evolution changelog belongs after the S-o-b and (first) ---
line.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block.c | 19 +++++++++++++
> qapi-schema.json | 27 +++++++++++++++++++
> qmp-commands.hx | 76
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 122 insertions(+), 0 deletions(-)
>
> ##
> +# @DeviceImageInfo:
> +#
> +# Information about image used by QEMU block device
s/image/an image/
>
> SQMP
> +query-images
> +-----------
> +
> +Show the block devices's images.
s/devices's/devices'/
> +
> +Each block image information is stored in a json-object and the returned
> value
> +is a json-array of all devices's image.
s/devices's image/devices' images/
The example is nice.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function, (continued)
- [Qemu-devel] [PATCH V2 04/11] qemu-img: switch image retrieving function, Wenchao Xia, 2013/01/09
- [Qemu-devel] [PATCH V2 07/11] block: export function bdrv_find_snapshot(), Wenchao Xia, 2013/01/09
- [Qemu-devel] [PATCH V2 02/11] block: add bdrv_get_filename() function, Wenchao Xia, 2013/01/09
- [Qemu-devel] [PATCH V2 08/11] qmp: add interface query-snapshots, Wenchao Xia, 2013/01/09
- [Qemu-devel] [PATCH V2 05/11] block: rename bdrv_query_info to bdrv_query_block_info, Wenchao Xia, 2013/01/09
- [Qemu-devel] [PATCH V2 09/11] hmp: export function hmp_handle_error(), Wenchao Xia, 2013/01/09
- [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images., Wenchao Xia, 2013/01/09
- Re: [Qemu-devel] [PATCH V2 06/11] qmp: add interface query-images.,
Eric Blake <=
- [Qemu-devel] [PATCH V2 10/11] hmp: retrieve info from qmp for snapshot info, Wenchao Xia, 2013/01/09
- [Qemu-devel] [PATCH V2 11/11] hmp: show snapshot on single block device, Wenchao Xia, 2013/01/09