Re: [Qemu-devel] [PATCH V2 03/11] block: add snapshot and image info query function

[Wenchao Xia]

于 2013-1-9 23:56, Eric Blake 写道:
> On 01/08/2013 10:12 PM, Wenchao Xia wrote:
> >    This patch added function bdrv_query_image_info() and
> > bdrv_query_snapshot_infolist(), which will return info in qmp object
> > format. The implemetion code are mostly copied from collect_image_info()
>
>
> s/implemetion/implementation/
OK.

> > and collect_snapshot() in qemu-img.c.
> >    To help filter out snapshot info not needed, a call back function is
> > added in bdrv_query_snapshot_infolist().
> >
> > v2:
>
> Generally, the v2 information should go...
  Do you know how to put change log under "---" in "git commit"?
I found it inconvenient to edit every ".patch" file, so added the
log directly in commit message.

> >    Seperate patch for adding these functions.
> >    Spelling fix.
> >    Coding style fix due to comments from Eric.
> >
> > Signed-off-by: Wenchao Xia <address@hidden>
> > ---
>
> ...here, after the S-o-b and --- separator.  It is useful for email
> review, but doesn't need to clutter the final git history.
>
> >   block.c               |  117 +++++++++++++++++++++++++++++++++++++++++++++++++
> >   include/block/block.h |    9 ++++
> >   2 files changed, 126 insertions(+), 0 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>


--
Best Regards

Wenchao Xia