Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

[Paolo Bonzini]

Il 07/01/2013 14:55, Gerd Hoffmann ha scritto:
> +void hmp_chardev_add(Monitor *mon, const QDict *qdict)
> +{
> +    const char *args = qdict_get_str(qdict, "args");
> +    Error *err = NULL;
> +    QemuOpts *opts;
> +
> +    opts = qemu_opts_parse(qemu_find_opts("chardev"), args, 1);
> +    if (opts == NULL) {
> +        error_setg(&err, "Parsing chardev args failed\n");
> +    } else {
> +        qemu_chr_new_from_opts(opts, NULL, &err);

This ought to use qmp_chardev_add and a generic opts->ChardevBackend
conversion.

But IMHO, this kind of intermediate conversion is okay, with the
"correct" thing deferred; being able to play with hotplug from HMP is
worth the small wart.  It's really Luiz's decision, so I'm not giving
the reviewed-by (yet).

Paolo

> +    }
> +    hmp_handle_error(mon, &err);
> +}
> +