[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/11] chardev: add file chardev support to char
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/11] chardev: add file chardev support to chardev-add (qmp) |
Date: |
Thu, 10 Jan 2013 11:35:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Il 10/01/2013 10:10, Gerd Hoffmann ha scritto:
>
>> > Do we need the complexity of supporting fd passing explicitly?
>> > 'getfd' is less than ideal compared to 'add-fd', and for 'add-fd',
>> > we would pass via "path":"/dev/fdset/nnn". That is, why do we need
>> > to bend over backwards to support an alternate syntax for fd
>> > passing in a new command, when we can already use existing commands
>> > to get fd passing for free?
> Oh, didn't know that. Was just following what SocketAddress does and
> what Paolo suggested. It isn't needed indeed.
Yeah, I hadn't followed fdset either. We really need more documentation.
Paolo
- Re: [Qemu-devel] [PATCH 07/11] chardev: add tty chardev support to chardev-add (qmp), (continued)