qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chard


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 11/11] chardev: add pty chardev support to chardev-add (qmp)
Date: Thu, 10 Jan 2013 11:42:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0

Il 09/01/2013 18:37, Eric Blake ha scritto:
> It also raises the question of whether unions even work with raw types,
> or whether you have to always go through a struct, in which case you
> should have used the 'String' wrapper instead of 'str', looking like:
> 
> { 'union': 'ChardevReturn', 'data': { 'pty'    : 'String',
>                                       'nodata' : 'ChardevDummy' } }
> ...
> <- { "return": { "type" : "pty", "data" : { "str" : "/dev/pty0" } } }

They do work with raw types.

If it is conceivable to add more data in the future, however, it's
better to use the wrapped types.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]