[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] unbounded qemu NetQue's ?
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] unbounded qemu NetQue's ? |
Date: |
Thu, 10 Jan 2013 13:29:19 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 07, 2013 at 03:27:30PM +0100, Luigi Rizzo wrote:
> On Mon, Jan 7, 2013 at 2:49 PM, Stefan Hajnoczi <address@hidden> wrote:
>
> > On Sun, Jan 06, 2013 at 08:23:56PM +0100, Luigi Rizzo wrote:
> > diff -urp qemu-1.3.0-orig/net/queue.c qemu-1.3.0/net/queue.c
> > > --- qemu-1.3.0-orig/net/queue.c 2012-12-03 20:37:05.000000000+0100
> > > +++ qemu-1.3.0/net/queue.c 2013-01-06 19:38:12.000000000 +0100
> > > @@ -92,6 +92,9 @@ static void qemu_net_queue_append(NetQue
> >
> > Please also do it for qemu_net_queue_append_iov().
> >
> >
> the qemu code has many duplicate functions of the form foo() and foo_iov() .
> Not only here, but even in the backents (e.g. see net/tap.c)
> I think it would be good to settle on a single version of the function
> and remove or convert the non-iov instances.
Yes. Patches welcome.
Stefan