Re: [Qemu-devel] [PATCH] MIPS: Translate breaks and traps into the appropriate signal

[Stefan Weil]

Am 10.01.2013 22:46, schrieb Meador Inge:
> GCC and GAS are capable of generating traps or breaks to check for
> division by zero.  Additionally, GAS is capable of generating traps
> or breaks to check for overflow on certain division and multiplication
> operations.  The Linux kernel translates these traps and breaks into
> signals.  This patch implements the corresponding feature in QEMU.
>
> Signed-off-by: Meador Inge <address@hidden>
> ---
>   linux-user/main.c |   64 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
>   target-mips/cpu.h |    6 +++++
>   2 files changed, 69 insertions(+), 1 deletion(-)


Hi,

please check your patch before submitting it to qemu-devel.
See also http://wiki.qemu.org/Contribute/SubmitAPatch.

Regards,

Stefan W.


$ scripts/checkpatch.pl 
0001-MIPS-Translate-breaks-and-traps-into-the-appropriate.patch
WARNING: braces {} are necessary for all arms of this statement
#62: FILE: linux-user/main.c:2329:
+                if (ret != 0)
[...]

WARNING: braces {} are necessary for all arms of this statement
#70: FILE: linux-user/main.c:2337:
+                if (code >= (1 << 10))
[...]

WARNING: braces {} are necessary for all arms of this statement
#73: FILE: linux-user/main.c:2340:
+                if (do_break(env, &info, code) != 0)
[...]

WARNING: braces {} are necessary for all arms of this statement
#83: FILE: linux-user/main.c:2350:
+                if (ret != 0)
[...]

WARNING: braces {} are necessary for all arms of this statement
#87: FILE: linux-user/main.c:2354:
+                if (!(trap_instr & 0xFC000000))
[...]

WARNING: braces {} are necessary for all arms of this statement
#90: FILE: linux-user/main.c:2357:
+                if (do_break(env, &info, code) != 0)
[...]

total: 0 errors, 6 warnings, 89 lines checked

0001-MIPS-Translate-breaks-and-traps-into-the-appropriate.patch has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.