[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 17/17] target-i386: remove setting tsc-frequency fro
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH 17/17] target-i386: remove setting tsc-frequency from x86_def_t |
Date: |
Fri, 11 Jan 2013 03:10:31 +0100 |
Setting tsc-frequency from x86_def_t is NOP because default tsc_khz
in x86_def_t is 0 and CPUX86State.tsc_khz is also initialized to 0
by default. So there is not need to set ovewrite tsc_khz with default
0 because field was already initialized to 0.
custom tsc-frequency setting is not affected due to it is being set
without using x86_def_t (previous patch)
Field tsc_khz in x86_def_t becomes unused with this patch, so drop it
as well.
Signed-off-by: Igor Mammedov <address@hidden>
---
v2:
- rebased with "target-i386: move out CPU features initialization
in separate func" patch dropped
---
target-i386/cpu.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index c3e1792..af93673 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -357,7 +357,6 @@ typedef struct x86_def_t {
int family;
int model;
int stepping;
- int tsc_khz;
uint32_t features, ext_features, ext2_features, ext3_features;
uint32_t kvm_features, svm_features;
uint32_t xlevel;
@@ -1579,8 +1578,6 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
env->cpuid_ext4_features = def->ext4_features;
env->cpuid_7_0_ebx_features = def->cpuid_7_0_ebx_features;
env->cpuid_xlevel2 = def->xlevel2;
- object_property_set_int(OBJECT(cpu), (int64_t)def->tsc_khz * 1000,
- "tsc-frequency", &error);
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
x86_cpu_set_props(cpu, props, &error);
--
1.7.1
- Re: [Qemu-devel] [PATCH 05/17] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t, (continued)
- [Qemu-devel] [PATCH 07/17] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 08/17] target-i386: set custom 'vendor' without intermediate x86_def_t, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 10/17] target-i386: set custom 'xlevel' without intermediate x86_def_t, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 11/17] target-i386: set custom 'level' without intermediate x86_def_t, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 12/17] target-i386: set custom 'model-id' without intermediate x86_def_t, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 09/17] target-i386: print deprecated warning if xlevel < 0x80000000, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 13/17] target-i386: set custom 'stepping' without intermediate x86_def_t, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 17/17] target-i386: remove setting tsc-frequency from x86_def_t,
Igor Mammedov <=
- [Qemu-devel] [PATCH 14/17] target-i386: set custom 'model' without intermediate x86_def_t, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 16/17] target-i386: set custom 'tsc-frequency' without intermediate x86_def_t, Igor Mammedov, 2013/01/10
- [Qemu-devel] [PATCH 15/17] target-i386: set custom 'family' without intermediate x86_def_t, Igor Mammedov, 2013/01/10
- Re: [Qemu-devel] [PATCH qom-cpu 00/17] x86 CPU cleanup, part 3, Andreas Färber, 2013/01/14