[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp) |
Date: |
Fri, 11 Jan 2013 11:53:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
On 01/10/13 20:41, Eric Blake wrote:
> On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
>> Also alias the old parport name to parallel for -chardev.
>>
>> Signed-off-by: Gerd Hoffmann <address@hidden> ---
>> qapi-schema.json | 3 ++- qemu-char.c | 44
>> ++++++++++++++++++++++++++++---------------- qemu-options.hx |
>> 5 ++++- 3 files changed, 34 insertions(+), 18 deletions(-)
>>
>
>> ## -{ 'enum': 'ChardevPortKind', 'data': [ 'serial' ] } +{
>> 'enum': 'ChardevPortKind', 'data': [ 'serial', +
>> 'parallel' ] }
>>
>> { 'type': 'ChardevPort', 'data': { 'device' : 'str', 'type' :
>> 'ChardevPortKind'} }
>
> In patch 7, should the enum and type have separate documentation?
IMHO no, they belong together as ChardevPortKind is only used by
ChardevPort.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH v2 07/10] chardev: add serial chardev support to chardev-add (qmp), (continued)
- [Qemu-devel] [PATCH v2 05/10] chardev: add hmp hotplug commands, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 09/10] chardev: add socket chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 01/10] chardev: add error reporting for qemu_chr_new_from_opts, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 02/10] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 03/10] chardev: reduce chardev ifdef mess a bit, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 04/10] chardev: add qmp hotplug commands, with null chardev support, Gerd Hoffmann, 2013/01/10
- [Qemu-devel] [PATCH v2 10/10] chardev: add pty chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/10