Re: [Qemu-devel] [PATCH v3 09/10] chardev: add socket chardev support to chardev-add (qmp)

[Eric Blake]

On 01/11/2013 04:20 AM, Gerd Hoffmann wrote:
> qemu_chr_open_socket is splitted into two functions.  All initialization
> after creating the socket file handler is splitted away into the new

You still haven't incorporated my fix of s/splitted/split/g that I
raised against both v1 and v2.

> @@ -2458,10 +2536,7 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts 
> *opts)
>      if (!is_listen)
>          is_waitconnect = 0;
>  
> -    chr = g_malloc0(sizeof(CharDriverState));
> -    s = g_malloc0(sizeof(TCPCharDriver));
> -
> -    if (is_unix) {
> +     if (is_unix) {

And you still have a spurious mis-indentation here.  What's going on?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature