[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open()
From: |
mdroth |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths |
Date: |
Fri, 11 Jan 2013 11:44:56 -0600 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jan 11, 2013 at 11:25:01AM +0100, Markus Armbruster wrote:
> Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
> qga/channel-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index 5579185..b530808 100644
> --- a/qga/channel-posix.c
> +++ b/qga/channel-posix.c
> @@ -153,6 +153,7 @@ static gboolean ga_channel_open(GAChannel *c, const gchar
> *path, GAChannelMethod
> ret = ga_channel_client_add(c, fd);
> if (ret) {
> g_critical("error adding channel to main loop");
> + close(fd);
> return false;
> }
> break;
> --
> 1.7.11.7
>
- [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 2/6] qemu-ga: Drop pointless lseek() from ga_open_pidfile(), Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 1/6] qemu-ga: Document intentional fall through in channel_event_cb(), Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths, Markus Armbruster, 2013/01/11
- Re: [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths,
mdroth <=
- [Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path, Markus Armbruster, 2013/01/11
- [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open(), Markus Armbruster, 2013/01/11
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, Eric Blake, 2013/01/11
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, Luiz Capitulino, 2013/01/14
- Re: [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups, mdroth, 2013/01/14