qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer.


From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer.
Date: Sat, 12 Jan 2013 09:50:13 +0000

On Wed, Jan 9, 2013 at 9:44 PM, KONRAD Frédéric
<address@hidden> wrote:
> On 09/01/2013 21:40, Blue Swirl wrote:
>>
>> On Mon, Jan 7, 2013 at 6:41 PM,  <address@hidden> wrote:
>>>
>>> From: KONRAD Frederic <address@hidden>
>>>
>>> This remove the function pointer in VirtIODevice, and use only
>>> VirtioDeviceClass function pointer. It should be applied after all
>>> the device have been refactored.
>>>
>>> Signed-off-by: KONRAD Frederic <address@hidden>
>>> ---
>>>   hw/9pfs/virtio-9p-device.c |  2 --
>>>   hw/virtio-balloon.c        |  8 --------
>>>
>>> -        vdev->set_config(vdev, vdev->config);
>>> +    if (k->set_config)
>>
>> Still this one...
>>
>> and here the braces are missing.
>>
> yes, I fixed these in the newpatch-set (there are in the 3rd part).
>
> Any idea about why checkpatch.pl didn't spot them ?
> Do I use it wrong ?

Seems to be a bug in the script, I don't get warnings either.

>
> Thanks,
> Fred



reply via email to

[Prev in Thread] Current Thread [Next in Thread]