[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer.
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer. |
Date: |
Sat, 12 Jan 2013 09:50:13 +0000 |
On Wed, Jan 9, 2013 at 9:44 PM, KONRAD Frédéric
<address@hidden> wrote:
> On 09/01/2013 21:40, Blue Swirl wrote:
>>
>> On Mon, Jan 7, 2013 at 6:41 PM, <address@hidden> wrote:
>>>
>>> From: KONRAD Frederic <address@hidden>
>>>
>>> This remove the function pointer in VirtIODevice, and use only
>>> VirtioDeviceClass function pointer. It should be applied after all
>>> the device have been refactored.
>>>
>>> Signed-off-by: KONRAD Frederic <address@hidden>
>>> ---
>>> hw/9pfs/virtio-9p-device.c | 2 --
>>> hw/virtio-balloon.c | 8 --------
>>>
>>> - vdev->set_config(vdev, vdev->config);
>>> + if (k->set_config)
>>
>> Still this one...
>>
>> and here the braces are missing.
>>
> yes, I fixed these in the newpatch-set (there are in the 3rd part).
>
> Any idea about why checkpatch.pl didn't spot them ?
> Do I use it wrong ?
Seems to be a bug in the script, I don't get warnings either.
>
> Thanks,
> Fred
- [Qemu-devel] [PATCH 50/61] virtio-serial : cleanup : init and exit functions., (continued)
- [Qemu-devel] [PATCH 50/61] virtio-serial : cleanup : init and exit functions., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 42/61] virtio-rng-pci : switch to the new API., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 47/61] virtio-serial : add the virtio-serial device., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 61/61] virtio : cleanup : init and exit function., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 51/61] virtio-serial : cleanup : use QOM casts., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 56/61] virtio-9p : cleanup : QOM casts., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 59/61] s390-virtio-bus : cleanup, fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 57/61] virtio : remove the function pointer., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 22/61] virtio-scsi : show the VirtIOSCSI structure., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 58/61] virtio-pci : cleanup : init, exit and reset functions., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 53/61] virtio-9p : add the virtio-9p device., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 25/61] virtio-scsi : moving host_features from properties to transport properties., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 55/61] virtio-9p : cleanup : init function., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 54/61] virtio-9p-pci : switch to the new API., fred . konrad, 2013/01/07
- [Qemu-devel] [PATCH 60/61] virtio : remove virtiobindings., fred . konrad, 2013/01/07
- Re: [Qemu-devel] [PATCH 00/61] Virtio refactoring., Anthony Liguori, 2013/01/07