|
From: | Dmitry Fleytman |
Subject: | Re: [Qemu-devel] [PATCH V8 5/5] Adding VMXNET3 device implementation |
Date: | Sat, 12 Jan 2013 18:17:59 +0200 |
On Fri, Dec 07, 2012 at 01:15:09PM +0200, Dmitry Fleytman wrote:hw/virtio.c always uses be64 for its hwaddr pa field. That way you
> +static void vmxnet3_get_ring_from_file(QEMUFile *f, Vmxnet3Ring *r)
> +{
> +#if HWADDR_BITS == 64
> + r->pa = qemu_get_be64(f);
> +#else
> + r->pa = qemu_get_be32(f);
> +#endif
avoid the #ifdefs.
> +#if HWADDR_BITS == 64The hardware register interface is 2 32-bit registers. Can you use
> + VMSTATE_UINT64(drv_shmem, VMXNET3State),
> + VMSTATE_UINT64(temp_shared_guest_driver_memory, VMXNET3State),
> +#else
> + VMSTATE_UINT32(drv_shmem, VMXNET3State),
> + VMSTATE_UINT32(temp_shared_guest_driver_memory, VMXNET3State),
> +#endif
uint64_t for these fields and avoid the #ifdefs?
Daynix Computing Ltd.
Cell: +972-54-2819481
Skype: dmitry.fleytman[Prev in Thread] | Current Thread | [Next in Thread] |