Re: [Qemu-devel] Fix the glib deprecated APIs

[Stefan Hajnoczi]

On Fri, Jan 11, 2013 at 09:40:59PM +0530, Ramesh G wrote:
> Hi,
> 
> I got a couple of below compilation errors while compiling with glib >
> 2.32.
> 
> $ make
>   CC    ../trace/simple.o
> ../trace/simple.c: In function ‘trace_thread_create’:
> ../trace/simple.c:407:5: error: ‘g_thread_create’ is deprecated (declared
> at /usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use 'g_thread_new'
> instead [-Werror=deprecated-declarations]
> ../trace/simple.c: In function ‘trace_backend_init’:
> ../trace/simple.c:428:5: error: ‘g_cond_new’ is deprecated (declared at
> /usr/include/glib-2.0/glib/deprecated/gthread.h:275)
> [-Werror=deprecated-declarations]
> ../trace/simple.c:429:5: error: ‘g_cond_new’ is deprecated (declared at
> /usr/include/glib-2.0/glib/deprecated/gthread.h:275)
> [-Werror=deprecated-declarations]
> cc1: all warnings being treated as errors
> make: *** [../trace/simple.o] Error 1
> $
> 
> I found these APIs have been deprecated in 2.32.  Please find the patch
> attached which fixes this problem.  Please let me know your thoughts.

Hi Ramakrishnan,
Please follow the guidelines at http://wiki.qemu.org/Contribute/SubmitAPatch, 
especially:
 * Please submit patches inline instead of as attachments so reviewiers
   can reply and quote your code easily.
 * Please follow QEMU coding style and run scripts/checkpatch.pl on your
   patch before submitting it.

Thanks,
Stefan