[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC ppc-next v3 08/10] mac_nvram: QOM'ify MacIO NVRAM
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC ppc-next v3 08/10] mac_nvram: QOM'ify MacIO NVRAM |
Date: |
Mon, 14 Jan 2013 13:34:59 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> It was not qdev'ified before, turn it into a SysBusDevice and
> initialize it via static properties.
>
> Prepare Old World specific MacIO state and embed the NVRAM state there.
>
> Drop macio_nvram_setup_bar() in favor of sysbus_mmio_map() or
> direct use of Memory API.
[...]
> diff --git a/hw/macio.c b/hw/macio.c
> index 0e6fc8d..32f359c 100644
> --- a/hw/macio.c
> +++ b/hw/macio.c
[...]
> @@ -85,11 +93,22 @@ static int macio_common_initfn(PCIDevice *d)
> static int macio_oldworld_initfn(PCIDevice *d)
> {
> MacIOState *s = MACIO(d);
> + OldWorldMacIOState *os = OLDWORLD_MACIO(d);
I find aliasing pointers like these mildly confusing, and prefer to
avoid aliases. Matter of taste, I guess.
> + SysBusDevice *sysbus_dev;
> int ret = macio_common_initfn(d);
> if (ret < 0) {
> return ret;
[...]
- [Qemu-devel] [RFC ppc-next v3 00/10] target-ppc: MacIO QOM'ification, Andreas Färber, 2013/01/13
- [Qemu-devel] [RFC ppc-next v3 10/10] cuda: QOM'ify CUDA, Andreas Färber, 2013/01/13
- [Qemu-devel] [PATCH 01/10] qom: Make object_resolve_path_component() path argument const, Andreas Färber, 2013/01/13
- Re: [Qemu-devel] [PATCH 01/10] qom: Make object_resolve_path_component() path argument const, Markus Armbruster, 2013/01/14
- Re: [Qemu-devel] [PATCH 01/10] qom: Make object_resolve_path_component() path argument const, Andreas Färber, 2013/01/14
- Re: [Qemu-devel] [PATCH 01/10] qom: Make object_resolve_path_component() path argument const, Markus Armbruster, 2013/01/14
- [Qemu-devel] Go along with glib's basic type typedef silliness? (was: [PATCH 01/10] qom: Make object_resolve_path_component() path argument const), Markus Armbruster, 2013/01/14
- Re: [Qemu-devel] Go along with glib's basic type typedef silliness? (was: [PATCH 01/10] qom: Make object_resolve_path_component() path argument const), Blue Swirl, 2013/01/17
- Re: [Qemu-devel] Go along with glib's basic type typedef silliness?, Markus Armbruster, 2013/01/18