[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/8] qemu-ga: Plug file descriptor leak on ga_open_p
From: |
Michael Roth |
Subject: |
[Qemu-devel] [PATCH 5/8] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path |
Date: |
Mon, 14 Jan 2013 13:55:09 -0600 |
From: Markus Armbruster <address@hidden>
Spotted by Coverity. Also document why we keep it open on success.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
---
qga/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qga/main.c b/qga/main.c
index 96d3cfa..db281a5 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -299,10 +299,12 @@ static bool ga_open_pidfile(const char *pidfile)
goto fail;
}
+ /* keep pidfile open & locked forever */
return true;
fail:
unlink(pidfile);
+ close(pidfd);
return false;
}
#else /* _WIN32 */
--
1.7.9.5
- [Qemu-devel] [PULL 0/8] qemu-ga: cleanups and minor fixes, Michael Roth, 2013/01/14
- [Qemu-devel] [PATCH 4/8] qemu-ga: Drop pointless lseek() from ga_open_pidfile(), Michael Roth, 2013/01/14
- [Qemu-devel] [PATCH 1/8] qemu-ga: ga_open_pidfile(): use qemu_open(), Michael Roth, 2013/01/14
- [Qemu-devel] [PATCH 3/8] qemu-ga: Document intentional fall through in channel_event_cb(), Michael Roth, 2013/01/14
- [Qemu-devel] [PATCH 7/8] qemu-ga: Plug fd leak on ga_channel_open() error paths, Michael Roth, 2013/01/14
- [Qemu-devel] [PATCH 5/8] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path,
Michael Roth <=
- [Qemu-devel] [PATCH 6/8] qemu-ga: Plug fd leak on ga_channel_listen_accept() error path, Michael Roth, 2013/01/14
- [Qemu-devel] [PATCH 2/8] qemu-ga: add ga_open_logfile(), Michael Roth, 2013/01/14
- [Qemu-devel] [PATCH 8/8] qemu-ga: Handle errors uniformely in ga_channel_open(), Michael Roth, 2013/01/14
- Re: [Qemu-devel] [PULL 0/8] qemu-ga: cleanups and minor fixes, Anthony Liguori, 2013/01/15