Re: [Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

[Doug Goldstein]

On Mon, Jan 14, 2013 at 3:35 AM, Michael Tokarev <address@hidden> wrote:
> 14.01.2013 13:18, Gerd Hoffmann пишет:
>
>> On 01/12/13 09:20, Michael Tokarev wrote:
>>>
>>> Gerd, can you take a (maybe quick) look please?
>>>
>>> This bug is quite old and, as Peter notes, may be fixed in 1.3
>>> so there's no goo motivation to fix it for older version...
>>> I tried to reproduce (to be able to get a trace, or bisect) it
>>> several times on my machine but can't, even with devices other
>>> people reported as triggering it.  Please give some advice for
>>> Debian users ;)
>>
>>
>> Given the amount of fixes which went into usb (not just usb-host, but
>> also uhci/ehic emulation) since 1.1 there is nothing but upgrading I can
>> seriously suggest ...
>
>
> Well.  Big share of these fixes are in the new async code which
> were added for 1.2.  There aren't really much fixes for the original
> wrong behavour.
>
> I were looking at all usb-related changes since 1.1 up to current 1.3,
> and there aren't really many fixes in there which are not already
> picked for -stable.
>
> But ofcourse I overlooked the actual fix for this problem, which
> appears to be this commit:
>
>
> commit 72a04d0c178f01908d74539230d9de64ffc6da19
> Author: Hans de Goede <address@hidden>
> Date:   Wed Sep 12 15:08:40 2012 +0200
>
>      uhci: Don't queue up packets after one with the SPD flag set
>
>      Don't queue up packets after a packet with the SPD (short packet
> detect)
>      flag set. Since we won't know if the packet will actually be short
> until it
>      has completed, and if it is short we should stop the queue.
>
>      This fixes a miniature photoframe emulating a USB cdrom with the
> windows
>      software for it not working.
>
>      Signed-off-by: Hans de Goede <address@hidden>
>      Signed-off-by: Gerd Hoffmann <address@hidden>
>
> which I wanted to queue for 1.1-stable too, initially, but decided
> it isn't really needed ;)
>
> Thank you!
>
> /mjt
>

Can you go ahead and push this into the 1.1-stable repo then? I'd
rather see things that are accepted pushed into the various stable
repos than languish in someone's personal repo/list and then pushed
right before a new stable tarball is released.

-- 
Doug Goldstein