[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 9/10] chardev: add socket chardev support to
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 9/10] chardev: add socket chardev support to chardev-add (qmp) |
Date: |
Mon, 14 Jan 2013 14:36:28 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/14/2013 04:35 AM, Gerd Hoffmann wrote:
> qemu_chr_open_socket is split into two functions. All initialization
> after creating the socket file handler is split away into the new
> qemu_chr_open_socket_fd function.
>
> chr->filename doesn't get filled from QemuOpts any more. Qemu gathers
> the information using getsockname and getnameinfo instead. This way it
> will also work correctly for file handles passed via file descriptor
> passing.
>
> Finally qmp_chardev_open_socket() is the actual qmp hotplug
> implementation which basically just calls socket_listen or
> socket_connect and the new qemu_chr_open_socket_fd function.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qapi-schema.json | 28 ++++++++-
> qemu-char.c | 166 ++++++++++++++++++++++++++++++++++++-----------------
> 2 files changed, 138 insertions(+), 56 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 00/10] chardev hotplug patch series, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 04/10] chardev: add qmp hotplug commands, with null chardev support, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 10/10] chardev: add pty chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 07/10] chardev: add serial chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 03/10] chardev: reduce chardev ifdef mess a bit, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 02/10] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 08/10] chardev: add parallel chardev support to chardev-add (qmp), Gerd Hoffmann, 2013/01/11
- [Qemu-devel] [PATCH v3 01/10] chardev: add error reporting for qemu_chr_new_from_opts, Gerd Hoffmann, 2013/01/11
- Re: [Qemu-devel] [PATCH v3 00/10] chardev hotplug patch series, Eric Blake, 2013/01/11