[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 4/4] Add qemu-img compare documentation
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v8 4/4] Add qemu-img compare documentation |
|
Date: |
Mon, 14 Jan 2013 16:24:21 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/14/2013 03:26 AM, Miroslav Rezanina wrote:
> Adding documentation for new qemu-img subcommand compare.
>
> Signed-off-by: Miroslav Rezanina <address@hidden>
> ---
> qemu-img.c | 7 ++++++-
> qemu-img.texi | 32 ++++++++++++++++++++++++++++++++
> 2 files changed, 38 insertions(+), 1 deletions(-)
Your series is lacking a test case; it would be useful to test both
identical images, images that are identical only when not in strict
mode, and differing images.
> +Check if two images have the same content. You can compare images with
> +different format or settings.
> +
> +The format is probed unless you specify it by @var{-f} (used for
> @var{filename1}) and/or @var{-F} (used for @var{filename2}) option.
Long line; worth wrapping.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature