[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU |
Date: |
Tue, 15 Jan 2013 11:03:53 +0000 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Tue, 15 Jan 2013, Andreas Färber wrote:
> Use the global first_cpu variable to halt the CPU rather than using a
> local first_cpu initialized from qemu_get_cpu(0).
>
> This will allow to change qemu_get_cpu() return type to CPUState
> despite use of the CPU_COMMON halted field in the reset handler.
>
> Signed-off-by: Andreas Färber <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
> xen-all.c | 4 +---
> 1 Datei geändert, 1 Zeile hinzugefügt(+), 3 Zeilen entfernt(-)
>
> diff --git a/xen-all.c b/xen-all.c
> index 19bcfd1..110f958 100644
> --- a/xen-all.c
> +++ b/xen-all.c
> @@ -585,9 +585,7 @@ static void xen_reset_vcpu(void *opaque)
>
> void xen_vcpu_init(void)
> {
> - CPUArchState *first_cpu;
> -
> - if ((first_cpu = qemu_get_cpu(0))) {
> + if (first_cpu != NULL) {
> qemu_register_reset(xen_reset_vcpu, first_cpu);
> xen_reset_vcpu(first_cpu);
> }
> --
> 1.7.10.4
>
>
- [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-15, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 01/20] cpu: Move nr_{cores, threads} fields to CPUState, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 02/20] target-mips: Clean up mips_cpu_map_tc() documentation, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 03/20] cpu: Move numa_node field to CPUState, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 05/20] kvm: Pass CPUState to kvm_init_vcpu(), Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU, Andreas Färber, 2013/01/15
- Re: [Qemu-devel] [PATCH 06/20] xen: Simplify halting of first CPU,
Stefano Stabellini <=
- [Qemu-devel] [PATCH 07/20] exec: Return CPUState from qemu_get_cpu(), Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 08/20] kvm: Add fake KVM constants to avoid #ifdefs on KVM-specific code, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 11/20] target-i386: kvm_check_features_against_host(): Use feature_word_info, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 13/20] target-i386: check/enforce: Check all feature words, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 09/20] target-i386: Disable kvm_mmu by default, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 04/20] cpu: Move cpu_index field to CPUState, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 10/20] target-i386/cpu: Introduce FeatureWord typedefs, Andreas Färber, 2013/01/15
- [Qemu-devel] [PATCH 12/20] target-i386/cpu.c: Add feature name array for ext4_features, Andreas Färber, 2013/01/15