[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/4] w32: Make qemu_vfree() accept NULL like the POS
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 1/4] w32: Make qemu_vfree() accept NULL like the POSIX implementation |
Date: |
Tue, 15 Jan 2013 14:23:37 +0100 |
On POSIX, qemu_vfree() accepts NULL, because it's merely wrapper
around free(). As far as I can tell, the Windows implementation
doesn't. Breeds bugs that bite only under Windows.
Make the Windows implementation behave like the POSIX implementation.
Signed-off-by: Markus Armbruster <address@hidden>
---
util/oslib-win32.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index e7e283e..640194c 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -71,7 +71,9 @@ void *qemu_vmalloc(size_t size)
void qemu_vfree(void *ptr)
{
trace_qemu_vfree(ptr);
- VirtualFree(ptr, 0, MEM_RELEASE);
+ if (ptr) {
+ VirtualFree(ptr, 0, MEM_RELEASE);
+ }
}
/* FIXME: add proper locking */
--
1.7.11.7
- [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Markus Armbruster, 2013/01/15
- [Qemu-devel] [PATCH 3/4] win32-aio: Fix how win32_aio_process_completion() frees buffer, Markus Armbruster, 2013/01/15
- [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify, Markus Armbruster, 2013/01/15
- Re: [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Kevin Wolf, 2013/01/15
- Re: [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Stefan Hajnoczi, 2013/01/15