[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] block: Fix how mirror_run() frees its buffe
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] block: Fix how mirror_run() frees its buffer |
Date: |
Tue, 15 Jan 2013 15:20:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 15.01.2013 14:23, schrieb Markus Armbruster:
>> It allocates with qemu_blockalign(), therefore it must free with
>> qemu_vfree(), not g_free().
>>
>> Since I'm touching it anyway, move the free to a more obviosly correct
>> place.
>
> ...except that it's now leaked for all error cases but the first.
Brain fart caused by looking at the RHEL code, will respin.
- [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Markus Armbruster, 2013/01/15
- [Qemu-devel] [PATCH 3/4] win32-aio: Fix how win32_aio_process_completion() frees buffer, Markus Armbruster, 2013/01/15
- [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify, Markus Armbruster, 2013/01/15
- Re: [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Kevin Wolf, 2013/01/15
- Re: [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Stefan Hajnoczi, 2013/01/15