[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/8] pc: Fix unchecked strdup() by switching to fw_c
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 4/8] pc: Fix unchecked strdup() by switching to fw_cfg_add_string() |
Date: |
Wed, 16 Jan 2013 14:50:25 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/pc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index ba1f19d..bc5c33f 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -693,9 +693,7 @@ static void load_linux(void *fw_cfg,
fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_ADDR, cmdline_addr);
fw_cfg_add_i32(fw_cfg, FW_CFG_CMDLINE_SIZE, strlen(kernel_cmdline)+1);
- fw_cfg_add_bytes(fw_cfg, FW_CFG_CMDLINE_DATA,
- (uint8_t*)strdup(kernel_cmdline),
- strlen(kernel_cmdline)+1);
+ fw_cfg_add_string(fw_cfg, FW_CFG_CMDLINE_DATA, kernel_cmdline);
if (protocol >= 0x202) {
stl_p(header+0x228, cmdline_addr);
--
1.7.11.7
- [Qemu-devel] [PATCH 0/8] Fixes and cleanups around fw_cfg, Markus Armbruster, 2013/01/16
- [Qemu-devel] [PATCH 3/8] fw_cfg: New fw_cfg_add_string(), Markus Armbruster, 2013/01/16
- [Qemu-devel] [PATCH 4/8] pc: Fix unchecked strdup() by switching to fw_cfg_add_string(),
Markus Armbruster <=
- [Qemu-devel] [PATCH 7/8] fw_cfg: Use void *, size_t instead of uint8_t *, uint32_t for blobs, Markus Armbruster, 2013/01/16
- [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints, Markus Armbruster, 2013/01/16
- Re: [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints, Peter Lieven, 2013/01/24
- Re: [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints, Markus Armbruster, 2013/01/24
[Qemu-devel] [PATCH 8/8] vl: Use size_t for sizes in get_boot_devices_list(), Markus Armbruster, 2013/01/16