qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] aio-posix: Fix return value of aio_poll()


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2] aio-posix: Fix return value of aio_poll()
Date: Wed, 16 Jan 2013 19:27:55 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0

Am 16.01.2013 19:25, schrieb Kevin Wolf:
> aio_poll() must return true if any work is still pending, even if it
> didn't make progress, so that bdrv_drain_all() doesn't stop waiting too
> early. The possibility of stopping early occasionally lead to a failed
> assertion in bdrv_drain_all(), when some in-flight request was missed
> and the function didn't really drain all requests.
> 
> In order to make that change, the return value as specified in the
> function comment must change for blocking = false; fortunately, the
> return value of blocking = false callers is only used in test cases, so
> this change shouldn't cause any trouble.
> 
> Cc: address@hidden
> Signed-off-by: Kevin Wolf <address@hidden>

Argh, sent the wrong file. Stefan, can you please replace "aio-posix" by
"aio" in the subject line before applying?

Kevin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]