[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V1 10/12] qerror: Add QERR_DEVICE_NOT_DEDUPLICATED
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC V1 10/12] qerror: Add QERR_DEVICE_NOT_DEDUPLICATED. |
Date: |
Wed, 16 Jan 2013 16:00:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/16/2013 09:25 AM, Benoît Canet wrote:
> ---
> include/qapi/qmp/qerror.h | 3 +++
> 1 file changed, 3 insertions(+)
You don't want this patch; instead, code in later patches that currently
uses
error_set(errp, QERR_DEVICE_NOT_DEDUPLICATED,
bdrv_get_device_name(bs));
should instead call
error_setg(errp, "Device '%s' doesn't support deduplication",
bdrv_get_device_name(bs));
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC V1 02/12] qcow2: Add code to deduplicate cluster flagged with QCOW_OFLAG_TO_DEDUP., (continued)
- [Qemu-devel] [RFC V1 02/12] qcow2: Add code to deduplicate cluster flagged with QCOW_OFLAG_TO_DEDUP., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 07/12] qcow2: Add qcow2_pause_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 08/12] qcow2: Add qcow2_resume_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 09/12] qcow2: Make dedup status persists., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 12/12] qmp: Add block_resume_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 06/12] block: Add bdrv_pause_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 11/12] qmp: Add block-pause-dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 04/12] block: Add bdrv_is_dedup_running., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 05/12] block: Add bdrv_resume_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 10/12] qerror: Add QERR_DEVICE_NOT_DEDUPLICATED., Benoît Canet, 2013/01/16
- Re: [Qemu-devel] [RFC V1 10/12] qerror: Add QERR_DEVICE_NOT_DEDUPLICATED.,
Eric Blake <=
- [Qemu-devel] [RFC V1 03/12] block: Add bdrv_has_dedup., Benoît Canet, 2013/01/16