[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V1 11/12] qmp: Add block-pause-dedup.
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [RFC V1 11/12] qmp: Add block-pause-dedup. |
Date: |
Thu, 17 Jan 2013 12:20:15 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> > +#
> > +# @device: the name of the device to pause the deduplication on
> > +#
> > +# Returns: nothing on success
> > +# If @device is not a valid block device, DeviceNotFound
> > +# If @device is not deduplicated, DeviceNotDeduplicated
>
> I don't think you need this second error. A generic error is good
> enough unless we can prove that having a dedicated error class makes
> algorithmic sense for a given client, and I can't come up with such a
> scenario off the top of my head for libvirt.
Ok i'll remove it.
>
> > +SQMP
> > +block-pause-dedup
> > +------------
> > +
> > +Pause the deduplication on a device that support it.
>
> s/support/supports/
>
> I notice that between this and patch 12, you are adding two very similar
> commands (block-pause-dedup, block-resume-dedup); would it be any
> simpler to add a single command instead:
>
> { 'command': 'block-dedup-control',
> 'data': { 'device': 'str', 'enable': 'bool' } }
>
> where the user calls:
>
> { "execute": "block-dedup-control",
> "arguments": { "device": "ide0-hd0", "enable": false } }
>
> to pause, and "enable":true to resume?
Ok I'll merge these.
Regards
Benoît
- [Qemu-devel] [RFC V1 00/12] QCOW2 asynchronous deduplication, Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 01/12] block: Add BlockDriver function prototype to pause and resume deduplication., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 02/12] qcow2: Add code to deduplicate cluster flagged with QCOW_OFLAG_TO_DEDUP., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 07/12] qcow2: Add qcow2_pause_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 08/12] qcow2: Add qcow2_resume_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 09/12] qcow2: Make dedup status persists., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 12/12] qmp: Add block_resume_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 06/12] block: Add bdrv_pause_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 11/12] qmp: Add block-pause-dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 04/12] block: Add bdrv_is_dedup_running., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 05/12] block: Add bdrv_resume_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 10/12] qerror: Add QERR_DEVICE_NOT_DEDUPLICATED., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 03/12] block: Add bdrv_has_dedup., Benoît Canet, 2013/01/16