qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] win32-aio: use iov utility functions instead


From: Michael Tokarev
Subject: Re: [Qemu-devel] [PATCH v2] win32-aio: use iov utility functions instead of open-coding them
Date: Thu, 17 Jan 2013 17:51:05 +0400
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0

17.01.2013 17:06, Stefan Hajnoczi wrote:
On Thu, Jan 17, 2013 at 02:44:41PM +0400, Michael Tokarev wrote:
We have iov_from_buf() and iov_to_buf(), use them instead of
open-coding these in block/win32-aio.c

Please use qemu_iovec_from_buf() and qemu_iovec_to_buf() since we're
operating on a QEMUIOVector.

I'd remove qemu_iovec_{from,to}_buf() completely at this point
due to their trivialness and almost no gain in usage as polluting
the namespace (having too many trivial utility functions isn't
good).  Right now these are only used in one place - in
hw/dataplane/virtio-blk.c .

If not, we can at least inline them.

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]