[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication info
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication infos in qapi-schema.json. |
|
Date: |
Thu, 17 Jan 2013 08:38:29 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/17/2013 05:15 AM, Benoît Canet wrote:
>> +# @running: True if deduplication is running
>
> Internally QCOW2 deduplication state switch between STOPPED, STARTING, RUNNING
> and STOPPING.
>
> Should the running field be a status field reflecting all theses states in a
> string for example ?
> Or is the boolean ok ?
Outputting an enum of all four states may be the best for debugging
purposes.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC V1 01/14] qcow2: Add deduplication metrics structures., (continued)
- [Qemu-devel] [RFC V1 01/14] qcow2: Add deduplication metrics structures., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 05/14] qcow2: Collect undeduplicated cluster metric., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 04/14] qcow2: Collect deduplicated cluster metric., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 08/14] qcow2: Count cluster deleted metric, Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 09/14] qcow2: Count deduplication refcount overflow metric., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 07/14] qcow2: Count QCowHashNode removal from tree for metrics., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 06/14] qcow2: Count QCowHashNode creation metrics., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication infos in qapi-schema.json., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 14/14] qapi: Return virtual block device deduplication metrics in QMP, Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 13/14] qcow2: returns deduplication metrics and status via bdrv_get_info(), Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 11/14] block: Add deduplication metrics to BlockDriverInfo., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V1 12/14] qcow2: Add qcow2_dedup_update_metrics to compute dedup RAM usage., Benoît Canet, 2013/01/16