Re: [Qemu-devel] [PATCH 22/43] tcg/arm: fix TLB access in qemu-ld/st ops

[Peter Maydell]

On 3 December 2012 22:08, Michael Roth <address@hidden> wrote:
> +    assert(tlb_offset & ~0xfffff == 0);

This doesn't compile if configured with --enable-debug:

In file included from /home/petmay01/git/qemu/tcg/tcg.c:174:0:
/home/petmay01/git/qemu/tcg/arm/tcg-target.c: In function ‘tcg_out_qemu_ld’:
/home/petmay01/git/qemu/tcg/arm/tcg-target.c:1148:5: error: suggest
parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
/home/petmay01/git/qemu/tcg/arm/tcg-target.c: In function ‘tcg_out_qemu_st’:
/home/petmay01/git/qemu/tcg/arm/tcg-target.c:1357:5: error: suggest
parentheses around comparison in operand of ‘&’ [-Werror=parentheses]

(ubuntu gcc 4.6.3-1ubuntu5)

I think this patch went into stable too :-)

-- PMM